Eduard S.

This idea sounds really good to me! In general, I think trying to apply the same patterns consistently in all circuits is a very good idea to reduce complexity and...

Dependencies: - Specify MPT circuit inputs Useful link: https://github.com/privacy-scaling-explorations/mpt-witness-generator

> While i am looking at some implementation for example pi_circuit.rs, it contains public block data as part of the circuit, that means vk for pi_circuit is not a fixed...

In the SuperCircuit PR I added some functions to the TxCircuit and BytecodeCircuit that return the list of keccak inputs that they need. We could do a similar thing for...

The only missing part for this tasks is to handle the keccak inputs required by MPT circuit. This will be unblocked with https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/1416

Here are some details of this task taken from [an old issue](https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/222). In particular, the MPT witness generation needs to be integrated into the Circuit Input Builder, more or less...

Related to https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/812

> (1) Clearly all rows should be constrained. There should not be a concept of _selector_, meaning a flag that disables rules. Instead, there can be case flags, meaning a...

> Two solutions for this type of problem: > > (1) the selector must be exact same len with 1

Hi @drewstone We have an MPT circuit in the works, but it isn't ready yet. You can track it's progress via https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/398 Once the MPT circuit is ready it should...