llm_engineering icon indicating copy to clipboard operation
llm_engineering copied to clipboard
verified publisher icon ed-donner

Modified Website class to allow selenium. To be added to community co…

Open tyngbayi opened this issue 7 months ago • 1 comments

I modified Website class in week1 day1 notebook to allow selenium for scraping dynamic websites. Contributing this for addition to community-contributions.

tyngbayi avatar May 28 '25 21:05 tyngbayi

Hi Ed, merge only the latest commit as I made changes to the file in the first commit. Thanks.

tyngbayi avatar May 29 '25 02:05 tyngbayi

Hey @tyngbayi - I'm not sure it's possible to only merge 1 commit like that - I believe you need to push an update to the PR to remove those edited files from the PR.. ChatGPT can give you instructions if you're unsure. Thanks so much

ed-donner avatar Jun 01 '25 02:06 ed-donner

Hi @ed-donner I meant to merge the latest PR only if that's possible i.e. c46348d. I did follow the chatgpt instructions you shared. Sorry for the confusion.

tyngbayi avatar Jun 01 '25 11:06 tyngbayi

Closing this pull request and will create a new one with additional files for week 1.

tyngbayi avatar Jun 02 '25 18:06 tyngbayi