llm_engineering icon indicating copy to clipboard operation
llm_engineering copied to clipboard

My cont

Open moawiah opened this issue 9 months ago • 4 comments

Main Contribution: Added my solution for Week 2 project Check community contributions folder at Week 2

moawiah avatar Apr 17 '25 16:04 moawiah

Hey @moawiah thanks so much.. hey this PR involves changes to 17 files including many outside the community contributions folders. Would you be able to update it to only include your new contributions? Thanks so much Ed

ed-donner avatar Apr 25 '25 13:04 ed-donner

Hello @ed-donner - First of all, would like to take the chance to thank you for this nice course!

  • I created a new PR with clean additions for my solution for week 2 project only - https://github.com/ed-donner/llm_engineering/pull/348
  • Tried to upload this project to hugging face but did not work because I am using a local llama model - any ideas?

moawiah avatar Apr 25 '25 15:04 moawiah

Hey @moawiah - thanks so much.. Does your new PR replace this one? Should we close this one? I'm not sure about the local llama point - are you using HuggingFace transformers code? Please email me at [email protected] when you have a chance with more details! Thank you Ed

ed-donner avatar May 10 '25 15:05 ed-donner

Yes - we can close this PR - The 2nd one replaces it. thank you!

moawiah avatar May 10 '25 19:05 moawiah