llm_engineering icon indicating copy to clipboard operation
llm_engineering copied to clipboard

Completed Exercise day 2

Open mapatro opened this issue 10 months ago • 3 comments

Completed first exercise

mapatro avatar Feb 28 '25 04:02 mapatro

hey @mapatro it looks like your PR is changing an existing file in community-contributions. Was that intentional? If not, you might want to rename your contribution so it doesn't overwrite the existing one? Thanks so much Ed

ed-donner avatar Mar 01 '25 18:03 ed-donner

Should I rename to different nam3?

Mahesh

On Sat, Mar 1, 2025, 2:00 PM Ed Donner @.***> wrote:

hey @mapatro https://github.com/mapatro it looks like your PR is changing an existing file in community-contributions. Was that intentional? If not, you might want to rename your contribution so it doesn't overwrite the existing one? Thanks so much Ed

— Reply to this email directly, view it on GitHub https://github.com/ed-donner/llm_engineering/pull/226#issuecomment-2692367279, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGJ4B36EWI4UHJRIBFAIVL2SH7S7AVCNFSM6AAAAABYBMRJ36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSGM3DOMRXHE . You are receiving this because you were mentioned.Message ID: @.***> [image: ed-donner]ed-donner left a comment (ed-donner/llm_engineering#226) https://github.com/ed-donner/llm_engineering/pull/226#issuecomment-2692367279

hey @mapatro https://github.com/mapatro it looks like your PR is changing an existing file in community-contributions. Was that intentional? If not, you might want to rename your contribution so it doesn't overwrite the existing one? Thanks so much Ed

— Reply to this email directly, view it on GitHub https://github.com/ed-donner/llm_engineering/pull/226#issuecomment-2692367279, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGJ4B36EWI4UHJRIBFAIVL2SH7S7AVCNFSM6AAAAABYBMRJ36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSGM3DOMRXHE . You are receiving this because you were mentioned.Message ID: @.***>

mapatro avatar Mar 02 '25 00:03 mapatro

Yes please @mapatro - if you could rename it that would be much appreciated. Thanks so much

ed-donner avatar Mar 08 '25 12:03 ed-donner