collect.js icon indicating copy to clipboard operation
collect.js copied to clipboard

Published 20 hours ago • verified publisher icon ecrmnn

Support esm?

Open peterroe opened this issue 2 years ago • 8 comments

peterroe avatar Jun 06 '22 05:06 peterroe

Sure, I'll be more than happy to review a PR. Please feel free to submit one 😄

ecrmnn avatar Jun 06 '22 05:06 ecrmnn

I'm interested in trying to refactor it, and I'm going to refactor using vite and vitest, can I do this？

peterroe avatar Jun 27 '22 12:06 peterroe

Why would you need Vite to support ESM? Is there something I’m missing here?

ecrmnn avatar Jun 27 '22 12:06 ecrmnn

No, it's purely due to personal habits, but other than that, vite and vitest are faster and have more features, and make the refactored project more "younger"

peterroe avatar Jun 27 '22 12:06 peterroe

Would appreciate a PR. Please keep it vanilla without any dependencies 😊

ecrmnn avatar Jun 27 '22 12:06 ecrmnn

OK, I am also think we shouldn't change to much,maybe I should create a new repo like collect-es.js?

peterroe avatar Jun 27 '22 12:06 peterroe

Simply fork it and make a PR.

If you haven’t created a PR before you might want to check this out https://makeapullrequest.com/

ecrmnn avatar Jun 27 '22 13:06 ecrmnn

I create a new repo to support esm😊 : https://github.com/peterroe/collect-es

peterroe avatar Jul 17 '22 05:07 peterroe