Eric Poppenheimer

I am still a beginner with git, so probably didn't go about this the correct way. I updated my fork, will those updates transfer to this pull request? But the...

I added in the script that I used to test rotation_from_u_to_v, but it isn't configured correctly as a unit test. I am a little unsure how to integrate into your...

I made some really major changes to u_to_v function, to make it compatible with batches and to fix problems, since it wasn't very well tested when I submitted the PR....

Ah, doesn't work with different float64 objects...

Ok, I changed the Quaternion constructor again so that it now takes a default dtype of None, in which case it tries to use the dtype of wxyz, and if...

So I am really not quite sure what to do with the test cases. I never learned how to properly use test cases in my limited programming education. It looks...

I moved the test cases into your existing test class. Still not sure how that code runs, so I haven't tested the code inside the class, but it does run...

I have implemented the most recent round of changes. When I tried running the test I got a bunch of errors due to running things in eager mode. Looks like...

I have thought a little be more about the special case code in get_rotation_quaternion_from_u_to_v. I need any vector orthogonal to U. U cross x-axis will be either orthogonal or zero...

I am pretty sure the code itself works just fine. I have been using it for a while now and have not had any issues. The unit testing however is...