Updates supporting flux-recording at large number of locations along river corridor; other minor bug-fixes

[saubhagya-gatech]

Major Updates

• Treat Triangles Embedded in the Stream Mesh

Triangles with all three vertices on the stream mesh can cause issues for applications like stream network connectivity. They often can divert water from corridor through them and act like a braid. To deal with this a two-stage treatment is implemented, with user options to select the level of treatment. These options can be accessed through a optional flag treat_stream_triangles : {'None', 'moderate', 'strict'} in tessalate_river_aligned function:

• moderate: This will deploy refinement function of the triangle library, where stream triangles are identified and passed on for additional refinement. This can take of most of the triangles, however, it is not an strict enforcement as triangulation algorithm will try to balance between multiple constraints and refinement like angles and cell sizes.
• strict: This method will split the stream triangles that could not be refined with the moderate option, by providing additional point (mid point of the off-river-corridor edge) during triangulation.

See image below where a stream triangle was split; red markers depicts the original stream triangle.

• Add three-face discharge regions

Add labeled sets for three faces for each discharge point in the river corridor. The three faces include downstream shorter edge of the quad and two edges connecting two downstream vertices of the quad and non-quad vertice on the bank triangle. Corresponding upstreams cells (a quad and two triangles) are also added for <Parameter name="direction normalized flux relative to region" type="string" value="discharge_cell_region_name" /> in the ATS observation parameter list in the input file

• Refinement based on polygons Returns a graded refinement function based upon polygon area limits, for use with Triangle. Triangle area must be smaller than the area limit for the polygon when the triangle centroid is within the polygon

Minor updates:

• fix for nan values in LAI
• modis manager end date set to (2024, 1, 1)
• bug-fix in "bank integrity" step in hydro-conditioning of river corridor
• preserve catchment option made available in higher level functions like construct_river