watershed-workflow icon indicating copy to clipboard operation
watershed-workflow copied to clipboard

Published 20 hours ago • verified publisher icon ecoon

update to shapely 2.0

Open ecoon opened this issue 2 years ago • 4 comments

shapely 2.0 has a lot of breaking changes. Most notably, Multi* objects can no longer be indexed or iterated over, and shapely objects cannot have arbitrary attributes assigned to them. The latter is to be fixed in #24 but the former must also be dealt with.

See also https://github.com/shapely/shapely-rfc/blob/b6997eefce448d0834abf58efc70714a9afdaf08/rfc/0001-shapely-2.0-roadmap.md

ecoon avatar Mar 11 '22 17:03 ecoon

Pretty much all of these are now deprecated warnings in our current shapely in both conda environment files and in docker images.

ecoon avatar Mar 11 '22 17:03 ecoon

This will be done at the same time as #24

ecoon avatar Jul 26 '23 20:07 ecoon

Should https://github.com/environmental-modeling-workflows/watershed-workflow/blob/master/environments/create_envs.py#L12 be changed to 'shapely<2.0.0', until this is implemented?

jsta avatar Oct 13 '23 15:10 jsta

Yes it should be. I thought that was already the case? But git blame disagrees with me...

fixed in #74

ecoon avatar Oct 13 '23 18:10 ecoon