econte-sprig

Building with a locally modified version of rrweb I have tried deleting the following lines: 1. ```image_1.crossOrigin = 'anonymous';``` 2. `oldValue_1 ? (attributes.crossOrigin = oldValue_1) : image_1.removeAttribute('crossorigin');` 3. `else image_1.onload...

> @econte-sprig Thanks for your PR and detailed explanation, but your change is not working with the following case, and it explains why we need to set the `onload` event...

Sure: https://github.com/econte-sprig/rrweb-demo1 1. Clone the repo 2. Run `npm i` 3. Run `npm run start` 4. Press the 'Record' button to start recording with rrweb 5. You will see in...

> @econte-sprig Hi, thanks for your demo. It should work with the following change. And `rr_dataURL` attribute is in the full snapshot with a lazy way attached to the attribute...

> The reload of the image is caused by the cross-origin attribute add and remove, and this attribute is necessary when transforming the image with Canvas. [`toDataURL` will throw an...

Otherwise, how do I know when an event is finished changing and it is safe to do something with the event (such as store it or send it to the...

Just putting together a fix PR for this issue with inline images. [You can check it out here.](https://github.com/rrweb-io/rrweb/pull/1306) Let me know if you need anything, such as a more detailed...