HARK icon indicating copy to clipboard operation
HARK copied to clipboard

Editing things in the examples/ directory for consistency, articulating policy in documentation

Open sbenthall opened this issue 5 years ago • 6 comments

@llorracc writes here: https://github.com/econ-ark/HARK/pull/472#issuecomment-582010196

I think you should remove the "Doc" from their names if they are being explicitly moved into an area that is already designated for documentation.

LifeCycleModelExample ... though if it does go into the "examples" area it should lose the "Example" from its filename.

It would be a good idea to go through the examples/ drrectory, which will be used for documentation with #459 / #472 , and edit those notebooks for consistency. This would include rationalizing the naming. This process can result in a "Style Guide", which should be part of the "Contribution Documentation". #410

sbenthall avatar Feb 04 '20 20:02 sbenthall

Cleanup the structure of examples directory. Move example notebooks to ConsumptionSavings from individual folders.

MridulS avatar Aug 24 '20 17:08 MridulS

I think it would be better to use Markdown's code format this like rather than the LaTeX texttt formatting

sbenthall avatar Feb 24 '21 22:02 sbenthall

I see that making this change across all the examples is a bit complicated, as this is used widely, sometimes the code variable names are included in larger mathematical expressions, and the LaTeX formatting is used in the long parameter table lists. I see this as connected to issue #889 in that it reflects the ways HARK code has been written to crossover between LaTeX and Python. Maybe this aspect of the docs should be revisited when this is better sorted out conceptually.

sbenthall avatar Feb 24 '21 22:02 sbenthall

Possibly something more nuanced is needed. code format for class and method names, keeping latex for the mathematical objects --- i"ll try to stick with that for 1.0

sbenthall avatar Feb 24 '21 22:02 sbenthall

just getting the examples and demarks working is taking so much time, I can't do this by 1.0, especially because of notebook overwrites from other PRs.

sbenthall avatar Feb 28 '21 22:02 sbenthall

@nicksawhney

sbenthall avatar Jul 01 '21 19:07 sbenthall