HARK icon indicating copy to clipboard operation
HARK copied to clipboard

Support PyPI Trusted Publisher for making releases

Open MridulS opened this issue 6 months ago • 8 comments

Fixes https://github.com/econ-ark/HARK/issues/708

Keeping it in draft mode for now as we still need to turn on trusted publisher on pypi side https://docs.pypi.org/trusted-publishers/adding-a-publisher. I can do that if folks think we should go ahead with this :)

MridulS avatar May 07 '25 21:05 MridulS

So the idea is that rather than doing the old process of manually pushing to PyPI and concurrently making a release commit / tagging a version on GitHub, we would just do a version tag here and that would automatically propagate to a PyPI release?

mnwhite avatar May 10 '25 18:05 mnwhite

we would just do a version tag here and that would automatically propagate to a PyPI release?

Indeed! This is the recommended security practice too now.

MridulS avatar May 10 '25 18:05 MridulS

@llorracc @akshayshanker @alanlujan91 See above. I vote for this.

mnwhite avatar May 11 '25 01:05 mnwhite

@MridulS, thanks for the input. This sounds like a good idea.

llorracc avatar May 11 '25 21:05 llorracc

Alan pointed out that this change is part of the (oddly named) PR #1514. The current plan is that after we release v0.16.0, we will then quickly do v0.16.1 with only packaging / technology changes. So let's put this on hold for (hopefully) a short while.

mnwhite avatar May 14 '25 14:05 mnwhite

"cookie" https://github.com/scientific-python/cookie

alanlujan91 avatar May 14 '25 14:05 alanlujan91

I'm sure it means something, but my point is that the one word title with no verb isn't clear. My understanding/definition of "cookie" is:

  1. the round sweetdiscs that we om-nom-nom
  2. a file that websites deposit in your webcache

The cookie PR is related to neither, and the word "cookie" doesn't appear in the description anywhere.

mnwhite avatar May 14 '25 15:05 mnwhite

@alanlujan91 I was just overwhelmed by looking at all the merge conflicts it will create so trying to move in baby steps :D

MridulS avatar May 14 '25 20:05 MridulS

@MridulS Can this be merged? Simplifying the release workflow would be great.

mnwhite avatar Oct 30 '25 19:10 mnwhite

I set it up on pypi side too, we can test it out with the next release. Ideally shouldn't really break anything :)

If anything does go wrong, the release can be uploaded manually!

MridulS avatar Oct 30 '25 19:10 MridulS