gitdiff-parser icon indicating copy to clipboard operation
gitdiff-parser copied to clipboard

This package has type errors

Open kaiyoma opened this issue 1 year ago • 0 comments

If I install this package and run the type checker, a couple errors are detected in the package itself:

node_modules/.pnpm/[email protected]/node_modules/gitdiff-parser/index.d.ts:53:16 - error TS2714: The expression of an export assignment must be an identifier or qualified name in an ambient context.

53 export default {
                  ~
54     parse(source: string): File[];
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
55 };
   ~

node_modules/.pnpm/[email protected]/node_modules/gitdiff-parser/index.d.ts:54:34 - error TS1005:
 '{' expected.

54     parse(source: string): File[];
                                    ~


Found 2 errors in the same file, starting at: node_modules/.pnpm/[email protected]/node_modules/gitdiff-parser/index.d.ts:53

There's a PR to fix this (https://github.com/ecomfe/gitdiff-parser/pull/27) but it's been stale for 9 months for some reason. Can we get this fixed?

kaiyoma avatar Mar 13 '23 21:03 kaiyoma