Add `long long` to supported data types for arrays?

Open tom-j-h opened this issue 8 months ago • 2 comments

Some code added to JEDI-oops develop has broken builds for at least one user on Mac: https://github.com/JCSDA-internal/oops/issues/2973

It seems adding long long to the list of types in https://github.com/ecmwf/atlas/blob/develop/src/atlas/array/Array.h and https://github.com/ecmwf/atlas/blob/develop/src/atlas/array/ArrayView.h (maybe other places, I'm not sure...) would fix this. Is that possible, or is there a reason it's not there already?

Aug 01 '25 09:08 tom-j-h

There is no particular reason besides that long long is not a commonly used type and was never needed. I'm happy to receive a PR with the required changes, provided that this PR is tested and fixes the problem in the oops issue. It should be uncontroversial.

Aug 01 '25 18:08 wdeconinck

@wdeconinck thank you. We may or may not make a PR. I'll close this if not.

Aug 04 '25 08:08 tom-j-h