hacknical
hacknical copied to clipboard
ecmadao
I18n
I looked quickly in the repo and couldn't find any translation file. Also, it seems hard-coded. Could you extract it in a dedicated translation file? I'd basically add support for French/English languages.
For the record, your repo is top 10 trending GitHub projects today! Cheers :)
https://github.com/trending/javascript
@Vadorequest Wow coooooooooooooool! I even didn't think of that before. Actually, this website was designed for Chinese developers at first, but I'm also interested in supporting multiple languages. I'll work on that these days. Thank you!
Hey @Vadorequest Glad to say that I have support a basic English version now 😁 --> http://hacknical.com Atleast, github data analysis page totally support EN, and I'll working on resume page later. Thanks again !
Cooooooool :) I'll take a look at it soon! And add the French version.
Le 22 févr. 2017 6:11 PM, "ecmadao" [email protected] a écrit :
Hey @Vadorequest https://github.com/Vadorequest Glad to say that I have support a basic English version now 😁 --> http://hacknical.com http://hacknical.com/user/login?locale=en Atleast, github data analysis page totally support EN, and I'll working on resume page later. Thanks again !
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ecmadao/hacknical/issues/15#issuecomment-281735303, or mute the thread https://github.com/notifications/unsubscribe-auth/ADoY4oEzIr_FPMqaJ8yi0lJ7XHR90zPaks5rfGxTgaJpZM4MH5tG .
@ecmadao PR done! (english only yet, I'll add FR when we're good with EN)
I looked at the website, almost everything is translated now, thanks!
I shared you website on Slack and I got a mix of English/Chinese in the preview mode:
I guess this part has been missed ;)
@Vadorequest Pretty cool. I'm quite sure that I have few mistakes on translation, glad to see you are working on them. THX!
@ecmadao FR version added + minor EN review
https://github.com/ecmadao/hacknical/pull/32
@Vadorequest
The bug of texts in chart has fixed now, and FR version is initialized now, cool!!! I'm really appreciate of your contributions.
However, if we wanna totally support FR, we also have to check locale files at frontend locales folder, then add new file names fr.js in each folder. Besides, you can find and check EN locale files there.
As for me, I will working on fetching orgs info for each user, and analyse users contributions for each forked & org repository.
@ecmadao I'll use files with the name fr.js and not fr-FR.js, following the same pattern as the en.js. Good for you?
A few questions:
- I wonder what you mean by
PV? - I didn't understood until now that
Resume Share Datas / GitHub Share Dataswere "tabs" I thought they were just text, not links, maybe it should be made more obvious? - About the Platform and Browser, "Max Platform", don't you mean "Preferred platform" instead? I guess you can somehow figure out what's the platform/browser GitHub users use? I didn't know it was possible.
But I think the english version must be reviewed by a chinese-english speaker first, it's not really easy to translate as it, and it feels like the choice of the words can be improved ;)
Note that the french version is not fully covered yet, sometimes I don't really how I should translate ^^
@Vadorequest
Use fr.js instead of fr-FR.js is cool.😁
PV means Page view, and Max Platform is what you think, I record each visit to the shared link, and figure out most preferred platform visitors used. It's my fault to not translate it clearly.
Besides, thanks for your advance of Resume Share Datas / GitHub Share Datas tab, I'll find a better way to show them.
Soooo sorry for my pool English transition that bothered you.😵
@ecmadao It's fine, don't worry ;) I took a look at your other repo and I also like the GitHub extension! Besides, I sucked at English for so long... If we have had that discussion 5 years ago you'd have looked like Shakespeare to me! ^_^