jsonforms icon indicating copy to clipboard operation
jsonforms copied to clipboard

refactor(core): resolve circular dependencies

Open LukasBoll opened this issue 1 year ago • 4 comments

Eliminated circular dependencies in the core module and reorganized package structure.

Ref #2321

LukasBoll avatar Jun 11 '24 12:06 LukasBoll

Deploy Preview for jsonforms-examples ready!

Name Link
Latest commit 2dc1e472c09f56c2d3230dcabde4653bb95685ce
Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/667fc821a084ec00086f7422
Deploy Preview https://deploy-preview-2345--jsonforms-examples.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 11 '24 12:06 netlify[bot]

Coverage Status

coverage: 83.269% (-0.07%) from 83.337% when pulling 0b6758f49513724a99168ef57d7e21ec402b9621 on LukasBoll:resolve_dependencies into c00b664ced7bb17ca2ab838ce5da610790c76566 on eclipsesource:master.

coveralls avatar Jun 11 '24 13:06 coveralls

Coverage Status

coverage: 83.26% (-0.08%) from 83.337% when pulling 2dc1e472c09f56c2d3230dcabde4653bb95685ce on LukasBoll:resolve_dependencies into c3cead71d08ff11837bdeb5fbea66e5313137218 on eclipsesource:master.

coveralls avatar Jun 29 '24 08:06 coveralls

Hi @LukasBoll , thanks for the PR ❤️ The changes already look mostly good to me and no more circular dependency warnings are shown :) Besides two inline comments, I suggest renaming the folder stateToPropsMapper to simply mappers: Not all of the methods are mapping state to props but most of them map either state or dispatch to some kind of props or utility data structure.

Hi @lucas-koehler,

Thank you for the review! I updated everything according to your suggestions!

LukasBoll avatar Jun 29 '24 08:06 LukasBoll