jsonforms icon indicating copy to clipboard operation
jsonforms copied to clipboard

(core) Categorization interface does not have a 'label' property

Open jdwit opened this issue 2 years ago • 1 comments

I may be missing something but I think the Categorization interface should not extend Labeled; the top level element of a Category layout (type: "Categorization") does not have a label, the example JSON in the docs confirms this.

jdwit avatar Aug 30 '22 08:08 jdwit

Hi @jdwit,

~You are right!~ Thanks for the contribution :heart:

Edit: Actually looking at the code I did miss that the React Vanilla renderers are able to handle categorizations with labels. While a categorization with a label is not that useful if it's only a flat list, it makes much more sense in the case of nested categories/categorizations.

So we should maybe just keep the optional label for Categorizations in place.

sdirix avatar Sep 02 '22 14:09 sdirix

Closing this for now as indicated by the previous comment.

sdirix avatar Oct 04 '22 10:10 sdirix