jsonforms icon indicating copy to clipboard operation
jsonforms copied to clipboard

Published 20 hours ago • verified publisher icon eclipsesource

(Draft) angular/angular-material 13

Open JBBianchi opened this issue 3 years ago • 6 comments

An attempt to migrate angular related packaged to v13 for full Ivy support.

Changes applied:

  • (angular/angular-material) Migrated to Angular 13
  • (all) Migrated to TypeScript 4.6.4
  • (material) Fixed implicit any type

Notes: @jsonforms/material-renderers tests are failing.

Closes #1993

JBBianchi avatar Aug 02 '22 13:08 JBBianchi

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 02 '22 13:08 CLAassistant

Thank you for the PR! We'll take a look soonish!

sdirix avatar Aug 08 '22 05:08 sdirix

thanks @sdirix , let me know if I can help.

JBBianchi avatar Aug 10 '22 15:08 JBBianchi

I fixed all minor comments I discovered during my review, however the major points still need to be addressed:

  • All example apps within this repository must work
  • The broken test cases must be fixed
  • The Angular seed must be able to consume the new modules and continue to work

sdirix avatar Aug 12 '22 07:08 sdirix

As the tests for @jsonforms/material-renderers were failing, I didn't go further yet and run examples/seeds. I'll have a look at the angular/angular-material ones.

JBBianchi avatar Aug 12 '22 08:08 JBBianchi

I tried to progress on bit on that task recently but I'm running into issues with typedoc (need to remove the theme/ignoreCompilerErrors for instance) and vue conflicting versions.

Basically update Angular => update Typescript ==> update typedoc/ts-jest/vue-jest and so on.

JBBianchi avatar Sep 14 '22 13:09 JBBianchi