jsonforms
jsonforms copied to clipboard
Fix "dot-separated" paths by making paths type `string[]` (instead of `string`)
Fix "dot-separated" paths by making paths type string[]
(instead of string
) for react (in these packages: "core", "react" and "material-renderers")
eclipsesource/jsonforms#1849 eclipsesource/jsonforms#1831
I know this can't be merged now. Because of conflicts with unfixed packages (angular, vue, ...). But those can be fixed, as well.
Hi @mirismaili, thanks for the PR. We're already working on this, see https://github.com/eclipsesource/jsonforms/pull/1831
The main problem with the array approach is to not lose performance. Just replacing strings with arrays here will lead to massive degradation as the memoization of React will no longer work and therefore the whole form will rerender with every change.
Hi, Has the "dot-seperated" issue been resolved yet?
We came up with a better solution, documented it in #2153 and will start developing it soon. Therefore I'll close this PR as it's outdated.