jsonforms icon indicating copy to clipboard operation
jsonforms copied to clipboard

Array Layout Renderer should support delete confirmation dialog

Open PhilDay-CT opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe.

As per this discussion in the forum: Delete item confirmation in List rendered

At present the default (table) renderer for an array and the array layout render are inconsistent as the former has a delete confirmation dialog and the latter simply removes items.

Describe the solution you'd like

The Array layout renderer should also prompt for confirmation before deleting an item

Describe alternatives you've considered

Custom rendered, but this would be better if it was part of the core behaviour

Framework

React

RendererSet

Material

Additional context

No response

PhilDay-CT avatar Nov 19 '21 09:11 PhilDay-CT

If implemented the behavior whether to show the dialog should be controllable via the UI Schema options, e.g. showConfirmationDialog: true.

sdirix avatar May 24 '22 07:05 sdirix

Hi @sdirix the issue looks interesting can you give a little headsup on this one how can it be achieved via UI Schema. headsup in the sense like where should i debug and which files should i be touching.

Also will custom renderer would be accepted as solution?

howdyAnkit avatar Nov 26 '23 10:11 howdyAnkit

Hi @howdyAnkit,

This is where the delete button of the array layout is rendered. And this is where the delete is handled for the table.

As you can see, the table control invokes a delete dialog while the array layout just deletes it immediately. These implementations should be aligned and ideally configurable.

sdirix avatar Nov 27 '23 08:11 sdirix