Robert-André Mauchin

Please include the LICENSE file in the crate

1

Please include the LICENSE file in the published crate. Thanks.

Golang 1.12.6 on i686 and armv7: ``` Testing in: /builddir/build/BUILD/objecthash-d1e3d6079fc16f8f542183fb5b2fdc11d9f00866/_build/src PATH: /builddir/build/BUILD/objecthash-d1e3d6079fc16f8f542183fb5b2fdc11d9f00866/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin GOPATH: /builddir/build/BUILD/objecthash-d1e3d6079fc16f8f542183fb5b2fdc11d9f00866/_build:/usr/share/gocode GO111MODULE: off command: go test -buildmode pie -compiler gc -ldflags "-X github.com/benlaurie/objecthash/version=0 -X github.com/benlaurie/objecthash/version.commit=d1e3d6079fc16f8f542183fb5b2fdc11d9f00866 -extldflags '-Wl,-z,relro...

Custom commit messages: sentence casing and bz keywords

9

Hi, I'm not really keen on the current commit messages, either for import or updates. They are not capitalised and they don't include the correct format for bug numbers (Close:...

Go 1.16: TestRateCounterHighResolution fails

4

On Fedora Rawhide with Go 1.16 beta, the test TestRateCounterHighResolution fails: ``` Testing in: /builddir/build/BUILD/ratecounter-a05fe2ccb7bd521822002ddbd47903ac1ed1eb63/_build/src PATH: /builddir/build/BUILD/ratecounter-a05fe2ccb7bd521822002ddbd47903ac1ed1eb63/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin GOPATH: /builddir/build/BUILD/ratecounter-a05fe2ccb7bd521822002ddbd47903ac1ed1eb63/_build:/usr/share/gocode GO111MODULE: off command: go test -buildmode pie -compiler gc -ldflags "...

Tests fail on arches ppc64le, aarch64 and s390x

4

``` + go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\''' --- FAIL: TestEWMA1 (0.00s) ewma_test.go:64: 3 minute a.Rate(): 0.029872241020718428 != 0.02987224102071842 ewma_test.go:68: 4 minute a.Rate():...

Cargo.toml used by tests are not included in the generated package

2

It seems the tests are failing because the tests directory in the crate does not contain all the subdirectory like in the repo: ```bash $ ll tests/ drwxr-xr-x@ - bob...

Test failure on 32 bits arches

1

With version 0.0.2 on Golang 1.15, the tests are failing on ARMv7hl and i686: ``` Testing in: /builddir/build/BUILD/snappy-0.0.2/_build/src PATH: /builddir/build/BUILD/snappy-0.0.2/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin GOPATH: /builddir/build/BUILD/snappy-0.0.2/_build:/usr/share/gocode GO111MODULE: off command: go test -buildmode pie -compiler...

While running test in `signer/remote`, the tests fail with: ``` 2021/08/01 19:10:17 [INFO] 127.0.0.1:38086 - "POST /api/v1/cfssl/info" 200 2021/08/01 19:10:17 http: TLS handshake error from 127.0.0.1:59762: remote error: tls: bad...

Go 1.15 rc 1 on Fedora Rawhide armv7hl and i686: ``` --- FAIL: TestPrimitiveIntBinary (0.00s) integer_test.go:24: schema: "int"; Datum: -2147483647; Actual: "1"; Expected: "-2147483647" integer_test.go:30: schema: "int"; Datum: 1455301406; Actual:...

Signed-off-by: Robert-André Mauchin Fix the following error on Go 1.15: ``` Testing in: /builddir/build/BUILD/glog-d7cfb6fa2ccda15565f68f204d68907c80a5c977/_build/src PATH: /builddir/build/BUILD/glog-d7cfb6fa2ccda15565f68f204d68907c80a5c977/_build/bin:/builddir/.local/bin:/builddir/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin GOPATH: /builddir/build/BUILD/glog-d7cfb6fa2ccda15565f68f204d68907c80a5c977/_build:/usr/share/gocode GO111MODULE: off command: go test -buildmode pie -compiler gc -ldflags "-X github.com/istio/glog/version=0...