vorto icon indicating copy to clipboard operation
vorto copied to clipboard

Remove the GeneratorRunner from the code base

Open kolotu opened this issue 5 years ago • 1 comments

I would suggest to remove the GeneratorRunner from the code base. We can run the generators locally for testing / developing using the AWS SAM tools. Also the generators in the GeneratorRunner behave slightly differently from the generators on AWS.

The downside of AWS SAM is that it is significantly slower, as it starts and stops a docker container with every request to a generator, which can lead to lower performance of the Vorto Repository (locally only). For example on the details page, a separate request will be made to get the information for every generator - currently there are 5 generators. That means 5 docker containers will be started and stopped consecutively, to load the details page.

This can be mitigated, by only configuring the generators that you currently need, so not all the generators will be loaded. Another idea would be to unify the request, so it's just being sent once and returns the information on all the generators.

Also when not testing a specific generator, you can always reference the dev generators on AWS instead of running them locally.

If we decide to do this, the documentation (and the links to it) have to be updated.

kolotu avatar Jan 13 '20 15:01 kolotu

Further investigations needed to find out, whether debugging works in all cases.

kolotu avatar Jan 29 '20 12:01 kolotu