steady icon indicating copy to clipboard operation
steady copied to clipboard

Default JSON view breaks the mitigation tab

Open henrikplate opened this issue 2 years ago • 1 comments

The change of the JSON view with commit 09292c4aaa232cd962e6cefa2b8c543a399aee0b breaks the mitigation tab in https://github.com/eclipse/steady/blob/6ea5fc17db84bceb78633ead15686d72a5e96e39/frontend-apps/src/main/webapp/view/ArchiveDetail.controller.js#L103, because the library property constructTypeCountersis not populated any more. As a result, the whole mitigation tab remains empty.

@serenaponta Can you remember why you've introduced the change back then?

henrikplate avatar Sep 28 '22 11:09 henrikplate

As far as i remember i changed it to have the constructTypeCounters data available via the api used to populate the new "bloat" icontab that we added back then.

To be tested, but I would suggest to revert the change in https://github.com/eclipse/steady/commit/09292c4aaa232cd962e6cefa2b8c543a399aee0b and to update the default view at https://github.com/eclipse/steady/blob/6ea5fc17db84bceb78633ead15686d72a5e96e39/rest-backend/src/main/java/org/eclipse/steady/backend/model/view/Views.java#L38 to

public interface Default extends CountDetails {}

serenaponta avatar Sep 28 '22 11:09 serenaponta

Fixed in #579

serenaponta avatar Feb 24 '23 17:02 serenaponta