SRV connection do not work (with fix)

[edwin-oetelaar]

https://github.com/eclipse/paho.mqtt.python/blob/1eec03edf39128e461e6729694cf5d7c1959e5e4/src/paho/mqtt/client.py#L974

Please replace line with parameters instead of wrong positional arguments. Testen on python 2.7.x and 3.5.x fixes both.

return self.connect(host, port, keepalive, bind_address, clean_start, properties)

            # Edwin van den Oetelaar fixes this 2020-05-22
            return self.connect(host=host, port=port, keepalive=keepalive, bind_address=bind_address, clean_start=clean_start, properties=properties)

[TD22057]

In case this bug isn't clear - this is serious (i.e. breaking) issue. The connect line in client.py is not passing the arguments through in the correct locations to connect(). As far as I can see, this means args like clean_start don't work at all.

[edwin-oetelaar]

I am not sure how to contribute here even more than I already did. My code running a real project broke, I needed the SRV functions. I found the problem, debugged it, fixed it and submitted a patch. Who is responsible for maintaining this code base?

Also https://github.com/eclipse/paho.mqtt.python/issues/442#issue-521739758

[TD22057]

Any update on this? This bug breaks the client and is trivial to fix.

[and3rson]

Any updates? This really breaks the connect_srv and makes it unusable.

[edwin-oetelaar]

https://github.com/eclipse/paho.mqtt.python/blob/9782ab81fe7ee3a05e74c7f3e1d03d5611ea4be4/src/paho/mqtt/client.py#L951

this looks still not fixed

@icraggs : please fix what you broke