paho.mqtt.c icon indicating copy to clipboard operation
paho.mqtt.c copied to clipboard

Allow trace level to be set to LOG_ERROR

Open tobdub opened this issue 4 years ago • 2 comments

Signed-off-by: Tobias Dubois [email protected]

Thank you for your interest in this project managed by the Eclipse Foundation.

The guidelines for contributions can be found in the CONTRIBUTING.md file.

At a minimum, you must sign the Eclipse ECA, and sign off each commit.

To complete and submit a ECA, log into the Eclipse projects forge You will need to create an account with the Eclipse Foundation if you have not already done so. Be sure to use the same email address when you register for the account that you intend to use when you commit to Git. Go to https://accounts.eclipse.org/user/eca to sign the Eclipse ECA.

tobdub avatar Dec 29 '20 15:12 tobdub

Improves performance by ~10% for me in high performance mode.

tobdub avatar Apr 22 '21 19:04 tobdub

Why not just change level < LOG_ERROR to level <= LOG_ERROR ?

Because if the log level is set to e.g. LOG_SEVERE, the trace level would not be changed. It seems to make sense to set the trace level to the highest possible value if level > LOG_ERROR.

tobdub avatar May 05 '21 15:05 tobdub