paho.mqtt.android icon indicating copy to clipboard operation
paho.mqtt.android copied to clipboard

Subscribe should not return null (#262)

Open Governa opened this issue 5 years ago • 1 comments

Always returning null breaks the contract set in the function signature and documentation.

This affects all subscribes that receive IMqttMessageListener as parameter.

Please make sure that the following boxes are checked before submitting your Pull Request, thank you!

  • [x] You have signed the Eclipse ECA
  • [x] All of your commits have been signed-off with the correct email address (The same one that you used to sign the CLA)
  • [x] If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that you are fixing straight away that you add some Description about the bug and how this will fix it.
  • [x] If this is new functionality, You have added the appropriate Unit tests.

Governa avatar Oct 05 '19 00:10 Governa

Is this patch acceptable? Is there anything missing?

Governa avatar Jun 12 '20 22:06 Governa