openvsx icon indicating copy to clipboard operation
openvsx copied to clipboard

Review usage of `EntityManager.merge`

Open amvanbaren opened this issue 5 months ago • 0 comments

As @hoangphamEclipse points out in https://github.com/EclipseFdn/open-vsx.org/issues/2062#issuecomment-1889937331, EntityManager.merge updates a JPA entity.

Review the code to determine where merge is used intentionally to update the entity and where it isn't. Use EntityManager.find or another read operation without side effects to replace the calls to EntityManager.merge where it is used only to get a managed entity.

amvanbaren avatar Sep 19 '24 09:09 amvanbaren