openvsx icon indicating copy to clipboard operation
openvsx copied to clipboard

[Mirror] Stops mirroring versions when one fails validation

Open alvsan09 opened this issue 1 year ago • 2 comments

The current logic when mirroring versions stops the loop when a version fails, This prevents publishing of versions that may pass the validation, and if the failure happen of the oldest version, the new ones will not get published.

The relevant line of code is at: https://github.com/eclipse/openvsx/blob/e388b7e2f692c9446f648366145e8fcc3857177b/server/src/main/java/org/eclipse/openvsx/mirror/MirrorExtensionService.java#L146

An example is: BroadcomMFD.ccf The validation error below impacts earlier versions of it, but with the current logic non of the versions are mirrored.

2024-05-28T23:42:36.447Z ERROR 1 --- [ool-10-thread-2] o.e.o.m.DataMirrorJobRequestHandler : failed to mirror BroadcomMFD.ccf

org.eclipse.openvsx.util.ErrorResultException: Invalid URL in field 'homepage': .

alvsan09 avatar May 29 '24 18:05 alvsan09