openvsx icon indicating copy to clipboard operation
openvsx copied to clipboard

Server side rendering

Open spoenemann opened this issue 5 years ago • 6 comments

Currently the whole content is generated by React in the browser. Crawlers do not execute JavaScript, and so the content should be made available to them with other means.

spoenemann avatar Feb 06 '20 12:02 spoenemann

  • [x] We could generate a sitemap in the server: https://support.google.com/webmasters/answer/183668?hl=en&ref_topic=4581190

spoenemann avatar Feb 14 '20 12:02 spoenemann

Server-side-rendering could be done with GraalVM, but that will require quite some effort to get it right. For example, when loading an extension detail page, we'll need to inject the extension metadata and README content into the script instead of fetching it from the server (we're already on the server).

spoenemann avatar Apr 27 '20 10:04 spoenemann

Crawlers do not execute JavaScript

That seems not to be true, at least I can find open-vsx.org extensions on Google search. But server-side-rendering can still be beneficial.

spoenemann avatar May 11 '20 13:05 spoenemann

@kineticsquid Do you think this issue is still relevant?

amvanbaren avatar Nov 22 '22 11:11 amvanbaren

@amvanbaren Good question. @spoenemann @chrisguindon?

kineticsquid avatar Nov 22 '22 19:11 kineticsquid

@kineticsquid I would say yes. This feature request would help solve my recommendation that I posted on https://github.com/EclipseFdn/open-vsx.org/issues/1240#issuecomment-1305597304

I would recommend that the application is upgraded to include a different description per page.

chrisguindon avatar Nov 22 '22 21:11 chrisguindon