Search sortBy and sortOrder has no effect on results

[amvanbaren]

[vince-fugnitto]

The issue is related to how getExtensions will disreguard the order from searchHits when performing the .stream() and the call to findExtensions. Our searchHits is already ordered and sorted, but due to this processing we will always end up ordering by the extension id (long).

https://github.com/eclipse/openvsx/blob/84d01402f007233c8a1e5b28587e4f4784c7d3fd/server/src/main/java/org/eclipse/openvsx/LocalRegistryService.java#L709-L738

[xai]

Hi @amvanbaren! If you don't mind, I would like to take a look at this issue. @kkistm is also in the loop here. Would this be ok for you? Is there anything that was already started and that we should be aware of?

[amvanbaren]

Hi @xai, go ahead. No, there isn't anything that was already started.

[vince-fugnitto]

@xai thanks for the reminder, I meant to upstream the changes I had for fixing the issue (https://github.com/eclipse/openvsx/pull/861).