openvsx icon indicating copy to clipboard operation
openvsx copied to clipboard

Published 20 hours ago • verified publisher icon eclipse

Feature/issue 514

Open amvanbaren opened this issue 2 years ago • 8 comments

Fixes #514

Testing Steps

  • Open this PR in Gitpod using the Gitpod browser plugin. It will automatically setup Prometheus and Grafana.
  • Once the Gitpod workspace has initialized, you can view the dashboards on port 9999 (https://9999-<GITPOD_HOST>).
  • When Grafana prompts for credentials use: username: admin, password: admin. Just click skip when it asks for a new password.
  • Dashboards are located under Dashboards > General.

amvanbaren avatar Jan 30 '23 13:01 amvanbaren

@akosyakov @jeanp413 @filiptronicek @kineticsquid @chrisguindon @fredg02 @yiningwang11 I could use some extra 👀 on this PR. Are the metric calculations correct? Does it meet your requirements?

amvanbaren avatar Jan 30 '23 13:01 amvanbaren

@amvanbaren, I merged the commits from this PR, https://github.com/eclipse/openvsx/pull/667/commits, into my fork. I restarted my workspace. I can see the Grafana and Prometheus ports but they are not served. This is from my gitpod workspace, https://kineticsquid-openvsx-pj1w63erlez.ws-us84.gitpod.io/.

I'm guessing I didn't do this step correctly, Open this PR in Gitpod using the Gitpod browser plugin. It will automatically setup Prometheus and Grafana..

kineticsquid avatar Jan 31 '23 19:01 kineticsquid

@kineticsquid There's no need to merge. Install the Gitpod addon: https://addons.mozilla.org/nl/firefox/addon/gitpod/. Then at the top of the page, a Gitpod button is added: Schermafbeelding 2023-01-31 om 22 00 05

amvanbaren avatar Jan 31 '23 20:01 amvanbaren

@amvanbaren Pretty slick! I was able to get this to work and see the dashboard. A couple of questions.

  • What defines an error, e.g. a 5xx http response?
  • Are we also able to track the source of the call?

More general question. How does gitpod construct the workspace? I poked around a bit for some documentation, but didn't find any detail. It looks like gitpod creates the workspace by cloning the repo and then merging the PR.

kineticsquid avatar Feb 01 '23 17:02 kineticsquid

I think it is mostly a question to Eclipse folks. At Gitpod we have our own dashboards/alerts/SLOs which rely on spring metrics. We could share what we have if @kineticsquid if you think it would be useful to you.

akosyakov avatar Feb 02 '23 10:02 akosyakov

@kineticsquid

What defines an error, e.g. a 5xx http response?

An error is defined as a 5xx (server error) or 4xx (client error).

Are we also able to track the source of the call?

I think the IP address can be added to the data.

More general question. How does gitpod construct the workspace?

The Gitpod workspace is for demonstration purposes. The Eclipse IT team will have to setup Prometheus and Grafana themselves.

amvanbaren avatar Feb 02 '23 10:02 amvanbaren

@amvanbaren Even a 404 shows up as an error? It seems useful to separate our 5xx server errors from 4xx user errors.

On the gitpod workspace construction, I was attempting to ask a more general question. How does gitpod construct a workspace from a PR?

kineticsquid avatar Feb 06 '23 17:02 kineticsquid

@kineticsquid I've split server and client errors into separate panels.

Gitpod uses Docker to construct a workspace from a PR.

amvanbaren avatar Feb 07 '23 08:02 amvanbaren

Using https://github.com/eclipse/openvsx/pull/857 instead.

amvanbaren avatar Mar 18 '24 16:03 amvanbaren