openvsx icon indicating copy to clipboard operation
openvsx copied to clipboard

Add support for Azure AD token authentication for storage account

Open oboxer opened this issue 3 years ago • 3 comments

Description

Currently, SAS token is the only way to authenticate azure storage account. We'd like to add support for Azure AD token authentication.

Use case/motivation

Our internal system requires we use Azure AD credentials instead of SAS token. Microsoft also recommends the use of Azure AD credentials when possible as a security best practice.

Are you willing to submit a PR?

  • [x] Yes I am willing to submit a PR!

If y'all are interested in this, do let us know! And if y'all had tried it and decided not to implement Azure AD credentials due to problems/issues, please do share what those issues are. Thanks!

oboxer avatar Nov 15 '22 19:11 oboxer

Hi @oboxer, I think adding the option to authenticate with an Azure AD token has a clear use case. There are probably other organizations that can benefit from this feature, so please do submit a PR!

I haven't looked into Azure AD tokens myself. @spoenemann have you tried Azure AD tokens but decided not to implement them due to problems/issues?

cc @kineticsquid @akosyakov

amvanbaren avatar Nov 16 '22 09:11 amvanbaren

No I haven't looked into that. I just followed the approach that was documented by Microsoft at that time (summer 2020).

spoenemann avatar Nov 16 '22 10:11 spoenemann

Thanks! Will submit a PR when ready.

oboxer avatar Nov 29 '22 22:11 oboxer