openvsx icon indicating copy to clipboard operation
openvsx copied to clipboard

Alter extension warning for super_user

Open amvanbaren opened this issue 2 years ago • 3 comments

Fixes #474

Testing Steps

  • Publish extension using privileged user:
curl --location --request POST 'http://localhost:8080/api/-/publish?token=super_token' \
--header 'Content-Type: application/octet-stream' \
--data-binary '@<PATH_TO_VSIX>'
  • JSON response verified field should be true

amvanbaren avatar Jul 05 '22 10:07 amvanbaren

@filiptronicek super_token is linked to the super_user, which is an admin user. Should admin users also be considered to be privileged users?

amvanbaren avatar Jul 07 '22 12:07 amvanbaren

@amvanbaren thanks for that, now it makes sense, didn't spot that there's a difference. I think admin users can be considered privileged users, making extensions from them verified would make sense to me.

filiptronicek avatar Jul 07 '22 12:07 filiptronicek

thanks for that, now it makes sense, didn't spot that there's a difference.

Me neither. I was a bit too quick to assume the testing steps would just work. The last commit makes an admin a privileged user too.

amvanbaren avatar Jul 07 '22 12:07 amvanbaren