openvsx
openvsx copied to clipboard
Improve publishing using ovsx
Fixes #461
use allSettled in CLI, so that all publish processes finish Make publish retryable
Works for me, thanks for the patch!
find . -iname 'terraform-*-2.23.0.vsix'
./terraform-darwin-arm64-2.23.0.vsix
./terraform-darwin-x64-2.23.0.vsix
./terraform-win32-arm64-2.23.0.vsix
./terraform-linux-armhf-2.23.0.vsix
./terraform-linux-x64-2.23.0.vsix
./terraform-win32-ia32-2.23.0.vsix
./terraform-win32-x64-2.23.0.vsix
./terraform-linux-arm64-2.23.0.vsix
find . -iname 'terraform-*-2.23.0.vsix' | xargs -I{} npx ovsx publish --packagePath {}
🚀 Published hashicorp.terraform v2.23.0
🚀 Published hashicorp.terraform v2.23.0
🚀 Published hashicorp.terraform v2.23.0
🚀 Published hashicorp.terraform v2.23.0
🚀 Published hashicorp.terraform v2.23.0
🚀 Published hashicorp.terraform v2.23.0
🚀 Published hashicorp.terraform v2.23.0
🚀 Published hashicorp.terraform v2.23.0
Would be nice if the info message after publishing also mentioned the target, but I understand that may be stretching the scope of this PR! 😄
Would be nice if the info message after publishing also mentioned the target, but I understand that may be stretching the scope of this PR! 😄
I think we should move this to another PR, but it would be great to have! My idea was to have it like this (JS pseudocode :laughing:) so that it would output the platform any time it publishes something not universal. WDYT about this @radeksimko?
if (packagePlatform === "universal") {
console.info("🚀 Published hashicorp.terraform v2.23.0")
} else {
console.info("🚀 Published hashicorp.terraform v2.23.0 (macOS Apple Silicon)")
}
@filiptronicek I don't have too strong opinions but I think that the fact that the package is universal can also be useful.
@radeksimko good point! It would for sure be useful, I am thinking that it would probably give the most value for extensions which have had platform-specific versions in the past, or those that have a couple of platform-specific releases but a fallback universal
one to support all of the remaining platforms.
I am worried that it might be confusing to people starting out with VS Code extension development to see (universal)
, since vsce publish
is in comparison very minimalist and only outputs DONE Published {id} v{x.x.x}.
.