openvsx icon indicating copy to clipboard operation
openvsx copied to clipboard

Header blank for some extensions

Open deboer-tim opened this issue 4 years ago • 1 comments
trafficstars

I thought the header was completely missing for the Launch Darkly extension (ironic? is this a dark launch?), but then I tried to select it and realized that it's just dark text on dark background.

https://open-vsx.org/extension/launchdarklyofficial/launchdarkly-beta Screen Shot 2021-04-27 at 4 14 28 PM

deboer-tim avatar Apr 27 '21 20:04 deboer-tim

Ok that's a strange case. The extension declares that it wants a light theme, hence the dark text color:

https://github.com/launchdarkly/ld-vscode/blob/6a2d9d62253464a122064a031222ef210ed81ec6/package.json#L269

However, it does not specify any background color (galleryBanner.color), hence the website uses its default from the dark theme.

spoenemann avatar Apr 28 '21 11:04 spoenemann

It now looks OK. Schermafbeelding 2022-12-08 om 13 33 15

amvanbaren avatar Dec 08 '22 11:12 amvanbaren