openvsx icon indicating copy to clipboard operation
openvsx copied to clipboard

Remove support for `win32-ia32`

Open felipecrs opened this issue 11 months ago • 5 comments

Support for win32-ia32 target was removed from vsce a long time ago. I wonder if it should not be removed from ovsx too.

felipecrs avatar Dec 30 '24 14:12 felipecrs

ovsx uses vsce to package extensions (where target is used). ovsx doesn't validate the target, just passes it to vsce, so ovsx also doesn't support win32-ia32.

amvanbaren avatar Jan 13 '25 10:01 amvanbaren

Maybe it should be removed from code then?

https://github.com/eclipse/openvsx/blob/master/server/src/main/java/org/eclipse/openvsx/util/TargetPlatform.java#L18 https://github.com/eclipse/openvsx/blob/master/server/src/test/java/org/eclipse/openvsx/RegistryAPITest.java#L251 https://github.com/eclipse/openvsx/blob/master/webui/src/utils.ts#L152

felipecrs avatar Jan 13 '25 12:01 felipecrs

There are some extensions that support win32-ia32. Last publish was a year ago. @kineticsquid @tfroment Do you want to keep win32-ia32 (Windows 32-bit) support?

win32-ia32.csv

amvanbaren avatar Feb 20 '25 16:02 amvanbaren

I'd venture that Microsoft might have other reasons for removing the support from the VS Code Marketplace. I'm not sure I fully understand the pros and cons on this one. Does it cost anything to keep it? What happens to these extensions should we remove it?

kineticsquid avatar Feb 20 '25 18:02 kineticsquid

I personally just think it's pointless to keep code and support for something that can't even be published anymore given vsce no longer supports it. So, my point is about code cleanup.

felipecrs avatar Feb 20 '25 18:02 felipecrs