mraa icon indicating copy to clipboard operation
mraa copied to clipboard

CMake: Bump min version to 3.1

Open pylbert opened this issue 6 years ago • 4 comments

Removed function for setting c++11 standard in favor of using CMake 3.1 global:

set (CMAKE_CXX_STANDARD 11)

Signed-off-by: Noel Eck [email protected]

pylbert avatar Jul 31 '18 23:07 pylbert

It seems like this should also be captured in the mraa.pc file however I'm not sure of the BKM for adding CXXFLAGS to pkg-config. Variable maybe?

pylbert avatar Jul 31 '18 23:07 pylbert

I guess CMAKE_CXX_FLAGS would be the way - I have';t used that much, but some quick googling hasn't revealed anything better than that.

alext-mkrs avatar Aug 01 '18 19:08 alext-mkrs

I'm not going to get to this for a bit (moving). I will wrap it up asap when settled.

On Tue, Aug 7, 2018, 11:48 PM Brendan Le Foll [email protected] wrote:

@arfoll approved this pull request.

I still think dual .pc files is probably the only way here. But the best thing to do would be maybe to find out what other libs are doing before jumping to a solution :)

In the meantime Cmake 3.1 min is a good choice imho

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/intel-iot-devkit/mraa/pull/914#pullrequestreview-144286324, or mute the thread https://github.com/notifications/unsubscribe-auth/AOqVebN50Gbq_0dZ7Z0_r0JS3cjAf03wks5uOomvgaJpZM4VpjSM .

pylbert avatar Aug 08 '18 18:08 pylbert

@pylbert, let me bump this up, do you still plan to merge this one?

alext-mkrs avatar Nov 15 '18 20:11 alext-mkrs