mosquitto icon indicating copy to clipboard operation
mosquitto copied to clipboard

Fix libdir location in pkgconfig files.

Open richmattes opened this issue 10 months ago • 1 comments

The pkgconfig files currently hardcode the library directory as ${prefix}/lib, but the library installation directory in config.mk is set as ${prefix}/lib${LIB_SUFFIX}. This causes a mismatch between the library installation directory and the pkgconfig file on redhat-based 64-bit systems.

This commit remedies the issue for both the Makefile and CMake build by modifying the pkgconfig files to use CMAKE_INSTALL_LIBDIR instead of lib. In the CMake system, this directly reflects the installation path. The Makefiles were modified to replace CMAKE_INSTALL_LIBDIR with lib${LIB_SUFFIX}, matching the libdir definition in config.mk and following the pattern used in defining the prefix.

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if you haven't signed the Eclipse Contributor Agreement. If you aren't able to do that, or just don't want to, please describe your bug fix/feature change in an issue. For simple bug fixes it is can be just as easy for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • [x] Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • [x] Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • [ ] If you are contributing a new feature, is your work based off the develop branch?
  • [x] If you are contributing a bugfix, is your work based off the fixes branch?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] Have you successfully run make test with your changes locally?

richmattes avatar Apr 01 '24 03:04 richmattes

This should also address #2990.

richmattes avatar Apr 01 '24 03:04 richmattes