mosquitto icon indicating copy to clipboard operation
mosquitto copied to clipboard

feature: replace select by poll in library to eliminate select limita…

Open skolodzieski opened this issue 5 years ago • 3 comments

…tions on number of sockets.

Signed-off-by: Scott Kolodzieski [email protected]

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if you haven't signed the Eclipse Contributor Agreement. If you aren't able to do that, or just don't want to, please describe your bug fix/feature change in an issue. For simple bug fixes it is can be just as easy for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • [x] Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • [x] Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • [ ] If you are contributing a new feature, is your work based off the develop branch?
  • [ ] If you are contributing a bugfix, is your work based off the fixes branch?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you successfully run make test with your changes locally?

skolodzieski avatar Nov 10 '20 19:11 skolodzieski

We had an application with an excess of 128 sockets, which was failing with libmosuitto due to the use of select. Direct conversion to poll solved the issue.

skolodzieski avatar Nov 11 '20 19:11 skolodzieski

Is there any timeline for getting a poll patch in the mosquitto client library. This is causing client failures for our customers. I posted this pull request more than 8 months ago, and nothing.

skolodzieski avatar Jul 28 '21 13:07 skolodzieski

We are facing the same issue and would be glad if select is replaced by poll. Dear maintainers, what is missing to complete this PR and have it merged in master ?

samba2 avatar Aug 23 '22 12:08 samba2

Hi @skolodzieski. Thanks a lot for your patch!! :) Would you mind rebasing it against master to ease testing?

pablomh avatar Oct 13 '23 15:10 pablomh