mita icon indicating copy to clipboard operation
mita copied to clipboard

C code for LEDs is missing LED specifiers in LED-Enable/-Switch functions

Open sawtschuk-appropos opened this issue 6 years ago • 0 comments

The following XDK Live code:

setup myLedInstance : LED {
	var control = light_up(Red);
}

generates the following C code:

Retcode_T ConnectivityLEDMyLedInstance_Setup(void)
{
	Retcode_T ledSetupStatus = RETCODE_OK;
	ledSetupStatus = BSP_LED_Connect();
	if(ledSetupStatus != RETCODE_OK)
	{
		return ledSetupStatus;
	}

	ledSetupStatus = BSP_LED_Enable((uint32_t) );
	if(ledSetupStatus != RETCODE_OK)
	{
		return ledSetupStatus;
	} 		

	return NO_EXCEPTION;
}

/* ... */

Retcode_T ConnectivityLEDMyLedInstance_Control_Write(bool* value)
{
	if(*value == TRUE) {
		BSP_LED_Switch((uint32_t) , (uint32_t) BSP_LED_COMMAND_ON);
	} else {
		BSP_LED_Switch((uint32_t) , (uint32_t) BSP_LED_COMMAND_OFF);
	}
	_ledStatus = *value;

	return NO_EXCEPTION;
}

Here, the functions BSP_LED_Enable and BSP_LED_Switch do not provide the input representing the red LED.

sawtschuk-appropos avatar Jun 29 '18 11:06 sawtschuk-appropos