lsp4jakarta icon indicating copy to clipboard operation
lsp4jakarta copied to clipboard

On error validation

Open dalidia opened this issue 3 years ago • 0 comments

Resolves #249

dalidia avatar Apr 12 '22 06:04 dalidia

As we discussed, those navigation things are almost unusable without very careful monitoring of where they jump to next in the toolbar.

I wonder though if we might not position these to the right of the undo/redo or just to the right of the "file" actions?

image

I'm sure everyone will have an opinion and there will be no making everyone happy!

I'm just thinking that maybe, to some extent, we try to avoid shifting to the right things that have been fixed to the left forever. It's just a thought...

merks avatar Feb 16 '24 11:02 merks

Thanks for your feedback @merks. I added another mock up showing your option to the list (Intellij style).

thomasritter avatar Feb 16 '24 13:02 thomasritter

I don't have any preferences as to which, I think all options look fine.

As a side note: it is interesting, how few buttons are enough for IntelliJ and co. I have observed a similar shift in a Tool that is rather fringe but very dear to me: Lazarus IDE. This is the IDE a few years ago: and this is it now:

It is not as light-weight as IntelliJ, but they too seem to have noticed the trend to "reduce the buttons" - at least for the most prominent place which is at the top.

Wittmaxi avatar Feb 17 '24 09:02 Wittmaxi

Thanks for making a proper proposal out of the brainstorming result, @thomasritter! In my opinion, most of the options proposed so far are reasonable and an improvement over the current state.

I wonder though if we might not position these to the right of the undo/redo or just to the right of the "file" actions?

I second Ed's proposal. For me, it also feels better to position the navigation items right of the undo/redo ones (or at least right of the file items). The file and undo/redo actions are kind of "essential" for me, while the navigation items already feel kind of optional, which is why I would keep the "essential" ones left of them. But we should be aware that the "back" and "forward" buttons look rather similar to the "undo" and "redo" ones, so having them placed near each other might lead to confusion and/or accidental misuse.

Switch the buttons order

When you look at the previous screenshot you can see that the order was not optimized for positioning the buttons on the left. The following mock up shows how the buttons could be re-arranged to feel more natural.

I am not sure about this one. If we place the navigation items at the left and start with the "back" and "forward" ones, I see a high risk of confusion with the undo/redo functions, as mentioned above. I think the idea behind the current button order was to start with the local operations (navigation between annotation in a file) and to proceed with more global ones (navigation between files/editors). However, I see no problem in inverting the order if there is a reason to do so.

HeikoKlare avatar Feb 17 '24 16:02 HeikoKlare

But we should be aware that the "back" and "forward" buttons look rather similar to the "undo" and "redo" ones, so having them placed near each other might lead to confusion and/or accidental misuse.

To make them look more different we could this about changing the colors of two of them. At least the navigation buttons are used quite often also in other UIs. And there are lots of other yellow arrows that are derived from these.

backward_nav@2x last_edit_pos@2x history_nav@2x next_change_nav@2x next_diff_nav@2x next_nav@2x next_nav@2x next_nav@2x next_thread_nav@2x search_sortmatch@2x shift_l_edit@2x ...

The undo/redo once seem to be used less: redo_edit@2x runlast_co@2x relaunchf@2x debuglast_co@2x ...

But this won't help color-blind people. So maybe this is a bad proposal from my side.

BeckerWdf avatar Feb 20 '24 07:02 BeckerWdf

To make them look more different we could this about changing the colors of two of them.

Sounds reasonable to me.

But this won't help color-blind people. So maybe this is a bad proposal from my side

That's a valid point, but I would guess that color-blind people are more sensible for different shapes since they cannot rely on colors anyway, so probably for them it is easier to distinguish the two kinds of shapes than for those who are used to also rely on colors? But of course, if we have something else to better distinguish the two than (only) color, that would be great. Maybe we can "refresh" the undo/redo buttons in terms of both color and shape?

HeikoKlare avatar Feb 28 '24 10:02 HeikoKlare

Note that the most common form on color blindness cannot see the difference between red and green. They have two color receptors rather than three.

merks avatar Feb 28 '24 10:02 merks