lemminx icon indicating copy to clipboard operation
lemminx copied to clipboard

Use `ProcessHandle` instead of shell script to check for parent process

Open datho7561 opened this issue 4 months ago • 4 comments

See #1025

datho7561 avatar Sep 09 '25 13:09 datho7561

Code LGTM, but I haven't tested it. @datho7561 have you?

fbricon avatar Sep 09 '25 13:09 fbricon

I made sure it still runs as normal, but I haven't tried killing the parent process manually yet, I should do that...

datho7561 avatar Sep 09 '25 13:09 datho7561

What about binary? Is it working?

angelozerr avatar Sep 09 '25 13:09 angelozerr

I made sure that lemminx starts up properly, then closed all VS Code abnormally (killall -9 code), and ensured that eventually the lemminx process stopped. I did this for the java version and the binary on Linux.

datho7561 avatar Sep 09 '25 14:09 datho7561