kapua icon indicating copy to clipboard operation
kapua copied to clipboard

Published 20 hours ago • verified publisher icon eclipse

Move to Artemis as message broker

Open riccardomodanese opened this issue 2 years ago • 3 comments

Brief description of the PR. This pr replaces the ActiveMQ with ActiveMQ Artemis broker

Related Issue none

Description of the solution adopted The broker is replaced, the authentication logic is moved outside to a new service consumer (authentication service). The broker plugins and the code deployed inside the broker are very light now, just a tiny layer to adapt broker objects to those used by the external authentication service. The authentication service is built on top of Spring Boot and Camel. The communication between broker and authentication service is done through messaging system (AMQP). The current configuration uses the "event broker" as "service broker" but it can be customized to use whetever AMQP service the user likes.

Screenshots none

Any side note on the changes made This pr has a lot of impacts in several part of the application

riccardomodanese avatar Sep 20 '22 09:09 riccardomodanese

Codecov Report

Merging #3599 (2df0f2e) into feature-artemis (285604c) will decrease coverage by 9.48%. The diff coverage is 1.10%.

:exclamation: Current head 2df0f2e differs from pull request most recent head 08c0e67. Consider uploading reports for the commit 08c0e67 to get more accurate results

Impacted file tree graph

@@                  Coverage Diff                  @@
##             feature-artemis    #3599      +/-   ##
=====================================================
- Coverage              49.99%   40.50%   -9.49%     
+ Complexity               259      234      -25     
=====================================================
  Files                   1686     1652      -34     
  Lines                  32165    32810     +645     
  Branches                2642     2672      +30     
=====================================================
- Hits                   16080    13290    -2790     
- Misses                 15147    18722    +3575     
+ Partials                 938      798     -140
Impacted Files Coverage Δ
.../broker/artemis/plugin/security/PluginUtility.java 0.00% <0.00%> (ø)
...ua/broker/artemis/plugin/security/RunWithLock.java 0.00% <0.00%> (ø)
...broker/artemis/plugin/security/SecurityPlugin.java 0.00% <0.00%> (ø)
.../broker/artemis/plugin/security/ServerContext.java 0.00% <0.00%> (ø)
...a/broker/artemis/plugin/security/ServerPlugin.java 0.00% <0.00%> (ø)
...mis/plugin/security/connector/AcceptorHandler.java 0.00% <0.00%> (ø)
...ua/broker/artemis/plugin/security/context/Acl.java 0.00% <0.00%> (ø)
...temis/plugin/security/context/ConnectionToken.java 0.00% <0.00%> (ø)
...temis/plugin/security/context/SecurityContext.java 0.00% <0.00%> (ø)
...ker/artemis/plugin/security/event/BrokerEvent.java 0.00% <0.00%> (ø)
... and 346 more

codecov[bot] avatar Sep 20 '22 10:09 codecov[bot]

/request-license-review

Coduz avatar Sep 28 '22 09:09 Coduz

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files): https://github.com/eclipse/kapua/actions/runs/3142464313

github-actions[bot] avatar Sep 28 '22 09:09 github-actions[bot]