kapua icon indicating copy to clipboard operation
kapua copied to clipboard

EclipseInt - add initial implementation of Hono device registry servi…

Open dejanb opened this issue 6 years ago • 4 comments

…ces using Kapua

dejanb avatar Jun 25 '18 16:06 dejanb

Hi @dejanb and @stefanomorson , I was thinking about how to proceed with the integration between the code of this branch and this pr. I said in one of the last Kapua scum that we can integrate this pr into that branch but I'm not so sure now. Referring to the slides projected in the last Kapua scrum the code of this branch is related to the "1.1" scenario and the pr is related to the "after 1.1" scenario. So I was thinking if it's better to move the pr in a different branch since it doesn't need any code from this branch. For the name I can suggest something like feature-eclipseiotHonoRegistry or something more general if this branch will own the whole code changes needed for the "after 1.1" scenario.

What do you think?

riccardomodanese avatar Jun 29 '18 08:06 riccardomodanese

I just rebased the feature-eclipseIot branch to develop

riccardomodanese avatar Jun 29 '18 08:06 riccardomodanese

@riccardomodanese sounds good to me. I was thinking originally to have it all in one branch as they are both related to the integration effort, but they don't have to be.

dejanb avatar Jul 03 '18 16:07 dejanb

Codecov Report

Merging #1825 into feature-eclipseiot will increase coverage by 0.17%. The diff coverage is 40.64%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             feature-eclipseiot    #1825      +/-   ##
========================================================
+ Coverage                 54.97%   55.15%   +0.17%     
+ Complexity                 1723     1134     -589     
========================================================
  Files                      1140     1146       +6     
  Lines                     28002    28180     +178     
  Branches                   2491     2505      +14     
========================================================
+ Hits                      15395    15543     +148     
- Misses                    11583    11595      +12     
- Partials                   1024     1042      +18
Impacted Files Coverage Δ Complexity Δ
...e/kapua/converter/kura/proto/KuraPayloadProto.java 30.64% <ø> (ø) 2 <0> (ø) :arrow_down:
...t/commons/AbstractDeviceManagementServiceImpl.java 100% <ø> (ø) 4 <0> (ø) :arrow_down:
...apua/message/internal/KapuaMessageFactoryImpl.java 45.45% <0%> (ø) 0 <0> (ø) :arrow_down:
.../eclipse/kapua/message/xml/MessageXmlRegistry.java 30.76% <0%> (ø) 0 <0> (ø) :arrow_down:
...ssage/internal/transport/TransportPayloadImpl.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...clipse/kapua/transport/message/jms/JmsMessage.java 47.05% <0%> (ø) 4 <0> (ø) :arrow_down:
.../eclipse/kapua/message/transport/TransportQos.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../java/org/eclipse/kapua/commons/util/GZipUtil.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../kapua/message/transport/TransportMessageType.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...ssage/internal/transport/TransportMessageImpl.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a3c8a8...192806e. Read the comment docs.

codecov[bot] avatar Sep 28 '18 12:09 codecov[bot]