imagen icon indicating copy to clipboard operation
imagen copied to clipboard

Do not dispose Graphics2D field in finalizer

Open ktgw0316 opened this issue 1 year ago • 5 comments

There is an error in GraphicsJAI when one attempts to create a GraphicsJAI from an existing Graphics2D. If the GraphicsJAI goes out of scope it can ruin the original Graphics2D and causes some method invokations, such as g2d.fill(shape), to be ignored.

This bug was reported as JAI_CORE-96.

ktgw0316 avatar Oct 18 '24 03:10 ktgw0316

Hello @ktgw0316 thanks for the PR; we are just in the process of restarting this project (it was in a holding pattern pending funding).

I will be working with @aaime and others to review outstanding PRs before we start work on a 1.0 release.

jodygarnett avatar Apr 30 '25 17:04 jodygarnett

The report from eclipsefdn/eca seems to be triggered by using different emails in the commit messages:

Author(s) covered by necessary legal agreements arctica0316@gmil DOT com jody.garnett@gmil DOT com

Author Eclipse account cannot be found. Email: arctica0316@gm*il DOT com GitHub ID: ktgw0316

Since it the email is listed as both "covered" and "not found" we may need to ask for help.

@ktgw0316 have you signed the https://www.eclipse.org/legal/eca/ thing? Does your profile have the [email protected] email address listed?

jodygarnett avatar May 09 '25 16:05 jodygarnett

@pstankie you are listed as a contributor on the eclipsefdn repo. We have an issue with the eclipsefdn/eca bot both accepting and rejecting the email address "arctica0316@gmil DOT com".

jodygarnett avatar May 09 '25 16:05 jodygarnett

@jodygarnett

@ktgw0316 have you signed the https://www.eclipse.org/legal/eca/ thing? Does your profile have the [email protected] email address listed?

Yes, but I haven't connected my GitHub account to the Eclipse account. I've just connected it.

ktgw0316 avatar May 10 '25 03:05 ktgw0316

Thanks @ktgw0316 that resolved the check!

jodygarnett avatar May 10 '25 04:05 jodygarnett