Set rollout error state for failed creation, starting or deletion process

[herdt-michael]

Set rollout into error state in case of too many tries of starting, creating or deleting a rollout.

[hawkbit-bot]

Can one of the admins verify this patch?

[avgustinmm]

@herdt-michael, is this PR something that is to be processed? There was some time without a progress, and there are unresolved reviews. Anyway, what is the motivation of this feature? An rollout start/delete could fail many times because of temporary DB failures/overload or whatever. Do we need to put it in error state? What are the cases when rollout isn't recoverable? Could you provide a little bit motivation for the PR.

[herdt-michael]

@herdt-michael, is this PR something that is to be processed? There was some time without a progress, and there are unresolved reviews. Anyway, what is the motivation of this feature? An rollout start/delete could fail many times because of temporary DB failures/overload or whatever. Do we need to put it in error state? What are the cases when rollout isn't recoverable? Could you provide a little bit motivation for the PR.

Hi @avgustinmm , please excuse the late reply.

In cases where an exception has occurred during the handling of a rollout creation, with the next scheduler run the same rollout is processed again. The issue arises because the old scheduler run was not fully completed and ended up in an unexpected state. In some cases, this resulted in a mismatch between the target count and the targets actually included. With an error handling concept, for example, the creation of a rollout should be stopped with an error state rather than "forcing" trying to create a possibly corrupt rollout.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[herdt-michael]

Not required anymore.