CSV export of target data from Target Filter View

Open krishna-devolo opened this issue 4 years ago • 2 comments

This is a pull request continuing an earlier pull request. (The earlier pull request was from a previous developer in our organization. The commits were from his own private fork, and we have since created a fork from our organization.

Oct 19 '21 12:10 krishna-devolo

Can one of the admins verify this patch?

Oct 19 '21 12:10 hawkbit-bot

Hi @bogdan-bondar , thanks for your comments on PR #1046. I have taken your input to improve the PR.

In suggestions you had suggested using ByteArrayOutputStream#toByteArray(), but I have converted the outputStream to string and tested if entries match the target values I had specified. Is this OK, or does using the byteArray have advantages I am overlooking?

CircleCI reports a failed test with AMQP implementation - I am not sure how this pops up since the added code does not affect AMQP implementation. There are no test failures when I run the code locally, so not sure how to go about this failed test. Would love your input on this!

Oct 19 '21 13:10 krishna-devolo