hawkbit icon indicating copy to clipboard operation
hawkbit copied to clipboard

bugfix missing OidcUser principal class

Open mdaur opened this issue 3 years ago • 2 comments

This PR will fix an issue I encountered using hawkBit with OIDC authentication schema (SpringSecurity oauth2). If SecurityContextTenantAware.getCurrentUsername return a null value, multiple error come up across the application:

  • e.g. if you are assigning a deployment which causes a sp_action Some issues I encountered end up in the DB layer for the latest (e.g. Caused by: java.sql.SQLException: Column 'initiated_by' cannot be null) This fix at least ensures that there is a Username in case of OIDC usage. /Martin

mdaur avatar May 25 '21 14:05 mdaur

Can one of the admins verify this patch?

hawkbit-bot avatar May 25 '21 14:05 hawkbit-bot

Greetings @mdaur,

I've seen the same issue, and I've been testing your PR, it fixes nicely this issue. It seems to not be processed due top the Legal Agreements that you should accept on the commit, or on the Eclipse website.

Do you want to update this pull request ? Or I address a new one for the same issue ?

Best regards,

Axel

axelroy avatar Aug 11 '21 06:08 axelroy