hawkbit-extensions
hawkbit-extensions copied to clipboard
Fix open S3Object InputStream
Open S3Object InputStream when creating an instance of S3Artifact to make it reusable and prevent a wrong usage because of an unused open InputStream.
Signed-off-by: Michael Herdt [email protected]
@hawkbit-bot verify please
SonarQube analysis reported 3 issues
-
3 minor
Watch the comments in this conversation to review them.
Frankly speaking I believe that proposed changes make the code less understandable with S3Artifact being mutable and used in different context (e.g. exists()
is a duplicate of existsByTenantAndSha1()
but used in different context). We need to define more strict borders of responsibility between S3Artifact
and S3Repository
.