Fix open S3Object InputStream

Open herdt-michael opened this issue 4 years ago • 3 comments

Open S3Object InputStream when creating an instance of S3Artifact to make it reusable and prevent a wrong usage because of an unused open InputStream.

Signed-off-by: Michael Herdt [email protected]

Mar 12 '21 12:03 herdt-michael

@hawkbit-bot verify please

Mar 23 '21 17:03 bogdan-bondar

SonarQube analysis reported 3 issues

3 minor

Watch the comments in this conversation to review them.

Mar 23 '21 18:03 hawkbit-bot

Frankly speaking I believe that proposed changes make the code less understandable with S3Artifact being mutable and used in different context (e.g. exists() is a duplicate of existsByTenantAndSha1() but used in different context). We need to define more strict borders of responsibility between S3Artifact and S3Repository.

Apr 15 '21 11:04 bogdan-bondar