gef-classic icon indicating copy to clipboard operation
gef-classic copied to clipboard

Missing version property in exported GEF packages

Open ptziegler opened this issue 1 year ago • 4 comments

Some weeks ago I ran into an issue where -after the 2024-03 release- some plugins were throwing a NoClassDefFoundError because GEF was not updated properly. The problem: I use "Import-Packages" to declare the dependencies, which doesn't specify any version ranges. Because an older version was already installed, the Eclipse considered the version to be compatible and did not update it.

image

I don't think maintaining the versions manually is the solution here... And I'm open to suggestions on how this could be automated. My initial idea was to use the "Convert to Automatic Manifest Generation" and see how it goes, but perhaps there are other options?

ptziegler avatar Apr 02 '24 19:04 ptziegler

Can you elaborate on “not updated properly”?

This sounds like a familiar problem but I want to be sure it’s the same problem I’m imagining.

merks avatar Apr 02 '24 20:04 merks

Can you elaborate on “not updated properly”?

This sounds like a familiar problem but I want to be sure it’s the same problem I’m imagining.

It's this discussion here. The user updated to WindowBuilder 1.15 which depends on GEF 3.17 (or higher). But after the updated, GEF remained at the already existing 3.16.

ptziegler avatar Apr 02 '24 20:04 ptziegler

So one (the?) significant problem to address is that the packages should be versioned? I use Oomph's versioning tool in a number of projects to automate such a thing. It's generally kind of complementary to the API tools helping to manage the micro version within the IDE, including quick fixes to fix all problems. E.g., if you change the version of a bundle, there will be errors that the exported package version doesn't match the bundle version and a quick fix to fix that. Maybe that's useful/interesting?

merks avatar Apr 03 '24 05:04 merks

So one (the?) significant problem to address is that the packages should be versioned?

That's correct. I would like to specify a version range with which WindowBuilder is compatible, similar to what is already possible with the Required-Bundle header.

if you change the version of a bundle, there will be errors that the exported package version doesn't match the bundle version and a quick fix to fix that. Maybe that's useful/interesting?

Having a quick-fix would help, but it's having yet another step which keeps me concerned. In my little dream world, the package versions are automatically updated with the bundle version where you would only have to do the initial configuration.

ptziegler avatar Apr 03 '24 16:04 ptziegler

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Jul 03 '24 01:07 github-actions[bot]

Not even the platform is adding the version number to their exported platform, so I don't believe this is worth pursuing. From my side, the problem was resolved by adding the GEF dependency via the "Required-Bundle" header.

ptziegler avatar Jul 03 '24 04:07 ptziegler