elk icon indicating copy to clipboard operation
elk copied to clipboard

Root node not vertically centered with following node in certain cases

Open thmsgbrt opened this issue 2 years ago • 2 comments

Hello, I've been trying for a while to solve this issue and I would like to know if someone has an idea or if this is a bug. What I would like to achieve is the following: 0311292a-3752-43db-aa5e-bd2c495ee039

Which works fine when I'm not using the top-level hierarchyHandling:INCLUDE_CHILDREN, but now, as you can see, the node that comes after the children is not part of the layout anymore: Screenshot 2023-10-26 at 09 11 37

Here is a link to this config

Sorry for the poor wording of the issue, I'm far from a specialist 🙏. Thank you for reading

thmsgbrt avatar Oct 26 '23 07:10 thmsgbrt

Hi, to clearify, hierarchy handling is not the problem as seen here. This seems to be a general problem of hierarchical models.

@Eddykasp you recently looked at something similar, does this have to do with anything?

soerendomroes avatar Oct 26 '23 08:10 soerendomroes

This problem looks similar to the issues dealt with in https://github.com/kieler/KLighD/pull/171 and https://github.com/eclipse/elk/pull/955. This may be a related but distinct problem. I think that the port placement assumes that the inout port is positioned on the left side below in and uses that to calculate the minimum node size. Although this doesn't quite match up as should be expected if we remove the edge between out and inout.

Eddykasp avatar Oct 26 '23 08:10 Eddykasp